Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update link text and destination for db backup settings #1131

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

agustints
Copy link

Summary

This pull request updates the link text and destination in the database backup settings prompt to align with recent frontend UI changes introduced by the Dokploy redesign. The change ensures that users are directed to the correct page for configuring backup providers.

Detailed Description

What has been modified:

  • The link in the prompt advising users to set up a backup provider has been updated:
    • Old destination and text (pre-Dokploy redesign):
      • Link Text: Settings
      • Link Destination: /dashboard/settings/server
    • New destination and text (aligned with the Dokploy redesign):
      • Link Text: S3 Destinations
      • Link Destination: /dashboard/settings/destinations

Why this change was made:

  • Recent frontend UI changes by Dokploy restructured the settings page, which made the old link (/dashboard/settings/server) outdated and irrelevant for backup provider configuration.
  • The updated link now correctly reflects the new structure and directs users to the specific "S3 Destinations" page where backup providers are managed.
  • The change ensures a smooth user experience by preventing navigation to an incorrect or unrelated page.

Code context:

The change is localized to the user-facing message displayed when no backup provider is configured, prompting users to take corrective action.

Impact on the codebase:

  • UI Consistency: The update aligns the link text and destination with the new frontend structure.
  • No Breaking Changes: This is a purely text and routing update with no impact on functionality or backend logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants